Ensure acceptance test writes to temporary location #2204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acceptance test to a temporary location, as usual.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2204 +/- ##
==========================================
- Coverage 98.39% 95.41% -2.98%
==========================================
Files 124 146 +22
Lines 12212 14680 +2468
==========================================
+ Hits 12016 14007 +1991
- Misses 196 673 +477 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Kat-90
approved these changes
Oct 8, 2025
brhooper
approved these changes
Oct 9, 2025
Contributor
brhooper
left a comment
brhooper
left a comment
There was a problem hiding this comment.
Thanks for spotting this @gavinevans. This change looks fine to me.
gavinevans
added a commit
to gavinevans/improver
that referenced
this pull request
Oct 10, 2025
…tering * upstream/master: Minor correction to write the output file from the test_gam_at_sites acceptance test to a temporary location, as usual. (metoppv#2204) Adds option for a landmask ancillary to be passed into the CLI (metoppv#2202) Mobt775 Add SAMOS apply plugins and all CLIs (metoppv#2153) Recursive filter mask zeros modifications (metoppv#2199) Correct passing through of variables for QRF application (metoppv#2196)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2203
Description
This PR corrects the test_gam_at_sites acceptance test, so that it writes to a temporary location, as usual, rather than writing to the same directory as the KGOs.
Associated with metoppv/improver_test_data#111
Testing: